davidm-db commented on code in PR #47403:
URL: https://github.com/apache/spark/pull/47403#discussion_r1684096518
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -91,6 +105,12 @@ class SingleStatementExec(
}
override def reset(): Unit = isExecuted = false
+
+ def execute(session: SparkSession): Unit = {
+ isExecuted = true
+ val result = Some(Dataset.ofRows(session, parsedPlan).collect())
+ if (collectResult) data = result
Review Comment:
let's write it as
```
if (collectResult) {
data = result
}
```
even in such simple cases, for consistency and cleaner code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
