bozhang2820 commented on PR #46302: URL: https://github.com/apache/spark/pull/46302#issuecomment-2245432031
> Looks reasonable - can you add a test for this ? We can use `local` vs `local-cluster` to test the expected behavior I tried adding a unit test for local-cluster mode but found it a bit difficult: 1. The cleanup is done in a best-effort basis, and in local-cluster mode the shuffle blocks are less likely to be cleaned up in time. 2. There seems to be no API to get the MigratableResolver on executors. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
