cloud-fan commented on code in PR #46302: URL: https://github.com/apache/spark/pull/46302#discussion_r1689492527
########## sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ########## @@ -177,7 +177,9 @@ object SQLExecution extends Logging { shuffleIds.foreach { shuffleId => queryExecution.shuffleCleanupMode match { case RemoveShuffleFiles => - SparkEnv.get.shuffleManager.unregisterShuffle(shuffleId) + // Do not unregister the shuffle on MapOutputTracker here to trigger stage retry. + // Otherwise, downstream tasks will fail with MetadataFetchFailedException. + sc.shuffleDriverComponents.removeShuffle(shuffleId, Utils.isTesting) Review Comment: oh I see, can we add some comments to explain it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org