yaooqinn commented on code in PR #47533: URL: https://github.com/apache/spark/pull/47533#discussion_r1696716244
########## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala: ########## @@ -170,6 +170,16 @@ object StaticSQLConf { .intConf .createWithDefault(1000) + val SHUFFLE_EXCHANGE_MAX_THREAD_THRESHOLD = + buildStaticConf("spark.sql.shuffleExchange.maxThreadThreshold") + .internal() + .doc("The maximum degree of parallelism for doing preparation of shuffle exchange, " + + "which includes subquery execution, file listing, etc.") + .version("4.0.0") + .intConf + .checkValue(thres => thres > 0 && thres <= 1024, "The threshold must be in (0,1024].") + .createWithDefault(1024) Review Comment: Can you explain why we pick this number? It might create memory pressure on the driver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org