cloud-fan commented on code in PR #47533:
URL: https://github.com/apache/spark/pull/47533#discussion_r1701137491
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala:
##########
@@ -61,23 +61,43 @@ trait BroadcastExchangeLike extends Exchange {
*/
def relationFuture: Future[broadcast.Broadcast[Any]]
+ @transient
+ private lazy val promise = Promise[Unit]()
+
+ @transient
+ private lazy val scalaFuture: scala.concurrent.Future[Unit] = promise.future
+
+ @transient
+ private lazy val triggerFuture: Future[Any] = {
+ SQLExecution.withThreadLocalCaptured(session,
BroadcastExchangeExec.executionContext) {
+ // Trigger broadcast preparation which can involve expensive operations
like waiting on
+ // subqueries and file listing.
+ executeQuery(null)
Review Comment:
good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
