LuciferYang commented on code in PR #47543:
URL: https://github.com/apache/spark/pull/47543#discussion_r1697851854
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcEncryptionSuite.scala:
##########
@@ -17,20 +17,53 @@
package org.apache.spark.sql.execution.datasources.orc
+import java.lang.invoke.MethodHandles
+import java.util.{Map => JMap}
import java.util.Random
-import org.apache.orc.impl.HadoopShimsFactory
+import scala.collection.mutable
+import org.apache.orc.impl.{CryptoUtils, HadoopShimsFactory, KeyProvider}
+
+import org.apache.spark.SparkConf
import org.apache.spark.sql.Row
import org.apache.spark.sql.test.SharedSparkSession
class OrcEncryptionSuite extends OrcTest with SharedSparkSession {
import testImplicits._
+ override def sparkConf: SparkConf = {
+ super.sparkConf.set("spark.hadoop.hadoop.security.key.provider.path",
"test:///")
+ }
+
+ override def beforeAll(): Unit = {
+ // Backup `CryptoUtils#keyProviderCache` and clear it.
+ keyProviderCacheRef.entrySet()
Review Comment:
At this time, the content of `keyProviderCacheRef` might be
```
hadoop.java.security.SecureRandom -> org.apache.orc.impl.NullKeyProvider
```.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcEncryptionSuite.scala:
##########
@@ -17,20 +17,53 @@
package org.apache.spark.sql.execution.datasources.orc
+import java.lang.invoke.MethodHandles
+import java.util.{Map => JMap}
import java.util.Random
-import org.apache.orc.impl.HadoopShimsFactory
+import scala.collection.mutable
+import org.apache.orc.impl.{CryptoUtils, HadoopShimsFactory, KeyProvider}
+
+import org.apache.spark.SparkConf
import org.apache.spark.sql.Row
import org.apache.spark.sql.test.SharedSparkSession
class OrcEncryptionSuite extends OrcTest with SharedSparkSession {
import testImplicits._
+ override def sparkConf: SparkConf = {
+ super.sparkConf.set("spark.hadoop.hadoop.security.key.provider.path",
"test:///")
+ }
+
+ override def beforeAll(): Unit = {
+ // Backup `CryptoUtils#keyProviderCache` and clear it.
+ keyProviderCacheRef.entrySet()
Review Comment:
At this time, the content of `keyProviderCacheRef` might be
```
hadoop.java.security.SecureRandom -> org.apache.orc.impl.NullKeyProvider
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
