LuciferYang commented on PR #47543:
URL: https://github.com/apache/spark/pull/47543#issuecomment-2259627620

   > To achieve this, the pr also refactors `OrcEncryptionSuite`:
   > 1. Overrides `beforeAll` to back up the contents of 
`CryptoUtils#keyProviderCache`.
   > 2. Overrides `afterAll` to restore the contents of 
`CryptoUtils#keyProviderCache`.
   > 
   > This ensures that `CryptoUtils#keyProviderCache` is isolated during the 
test process of `OrcEncryptionSuite`.
   
   Without this change, `OrcEncryptionSuite` would fail because, after this PR, 
the implementation corresponding to key `hadoop.java.security.SecureRandom` in 
`CryptoUtils#keyProviderCache` has been designated as 
`org.apache.orc.impl.NullKeyProvider`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to