uros-db commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1699899573
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -42,28 +42,30 @@ case class Mode(
this(child, 0, 0, Some(reverse))
}
- // Returns null for empty inputs
- override def nullable: Boolean = true
-
- override def dataType: DataType = child.dataType
-
- override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
-
Review Comment:
why are we moving this code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
