mihailom-db commented on PR #47364: URL: https://github.com/apache/spark/pull/47364#issuecomment-2314426182
Hi, @panbingkun. Sorry for delay in the response. As adding this listing of collation functionality is making other changes necessary, I believe it might be good to keep this PR to only adding SHOW COLLATIONS syntax, and then we will think about how to add support for different catalogs and schemas when we actually introduce collations with these features (user defined collations). I will add some more comments soon, so you can rework this PR and we can merge it in soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
