panbingkun commented on code in PR #47364:
URL: https://github.com/apache/spark/pull/47364#discussion_r1738162472
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -342,6 +358,42 @@ private static int collationNameToId(String collationName)
throws SparkException
}
protected abstract Collation buildCollation();
+
+ protected String catalog;
+ protected String schema;
Review Comment:
Do you mean we remove the `Meta` class from here and let the `Collation`
include all the `fields` of the `Meta`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
