andrej-db commented on code in PR #48621:
URL: https://github.com/apache/spark/pull/48621#discussion_r1837049314
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -377,6 +378,17 @@ abstract class JdbcDialect extends Serializable with
Logging {
}
private[jdbc] class JDBCSQLBuilder extends V2ExpressionSQLBuilder {
+ def inputToCaseWhenSQL(input: Expression): String =
+ "CASE WHEN " + inputToSQL(input) + " THEN 1 ELSE 0 END"
+
+ def inputToIntSQL(expr: Expression): String = {
+ expr match {
+ case p: Predicate if p.name() != "ALWAYS_TRUE" && p.name() !=
"ALWAYS_FALSE" =>
Review Comment:
where? do not understand the question...
there are more dbs that do not support booleans, so sql server is not the
only one. it is for now though, but we should make it future-proof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
