cloud-fan commented on code in PR #48621:
URL: https://github.com/apache/spark/pull/48621#discussion_r1837509045
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -377,6 +378,17 @@ abstract class JdbcDialect extends Serializable with
Logging {
}
private[jdbc] class JDBCSQLBuilder extends V2ExpressionSQLBuilder {
+ def inputToCaseWhenSQL(input: Expression): String =
+ "CASE WHEN " + inputToSQL(input) + " THEN 1 ELSE 0 END"
+
+ def inputToIntSQL(expr: Expression): String = {
+ expr match {
+ case p: Predicate if p.name() != "ALWAYS_TRUE" && p.name() !=
"ALWAYS_FALSE" =>
Review Comment:
The code here assumes we don't need to turn `"ALWAYS_TRUE"` into int, as we
already turn it into int somewhere else without using CASE WHEN. We need to
prove that this assumption is true. Can you give me the code pointers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
