cloud-fan commented on code in PR #50875:
URL: https://github.com/apache/spark/pull/50875#discussion_r2095722405


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2105,6 +2105,12 @@ class Analyzer(override val catalogManager: 
CatalogManager) extends RuleExecutor
                   catalog, "table-valued functions")
               }
             }
+            if (u.isStreaming && !resolvedFunc.isStreaming) {
+              // If the function was marked as streaming in the SQL statement 
but it's determined
+              // through resolution that the underlying function does not 
actually produce a
+              // streaming relation, throw an unsupported streaming exception.
+              throw QueryCompilationErrors.unsupportedStreamingTVF(u.funcName)

Review Comment:
   to pass the fully qualified function name, we should do 
`ident.toQualifiedNameParts(catalog)` (this needs `import 
org.apache.spark.sql.connector.catalog.CatalogV2Implicits._`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to