cloud-fan commented on code in PR #50875:
URL: https://github.com/apache/spark/pull/50875#discussion_r2095724125
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala:
##########
@@ -1063,7 +1063,7 @@ class UnsupportedOperationsSuite extends SparkFunSuite
with SQLHelper {
/** Assert that the logical plan is supported as a batch plan */
def assertSupportedInBatchPlan(name: String, plan: LogicalPlan): Unit = {
test(s"batch plan - $name: supported") {
- UnsupportedOperationChecker.checkForBatch(plan)
+ UnsupportedOperationChecker.checkForBatch(plan = plan)
Review Comment:
Why this change? It's pretty common to pass the variable whose name is the
same as the function parameter name.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala:
##########
@@ -1073,7 +1073,7 @@ class UnsupportedOperationsSuite extends SparkFunSuite
with SQLHelper {
plan: LogicalPlan,
expectedMsgs: Seq[String]): Unit = {
testError(s"batch plan - $name: not supported", expectedMsgs) {
- UnsupportedOperationChecker.checkForBatch(plan)
+ UnsupportedOperationChecker.checkForBatch(plan = plan)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
