cloud-fan commented on code in PR #51196:
URL: https://github.com/apache/spark/pull/51196#discussion_r2160793362
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDataFrameDropColumns.scala:
##########
@@ -34,10 +34,16 @@ class ResolveDataFrameDropColumns(val catalogManager:
CatalogManager)
case d: DataFrameDropColumns if d.childrenResolved =>
// expressions in dropList can be unresolved, e.g.
// df.drop(col("non-existing-column"))
- val dropped = d.dropList.map {
+ val dropped = d.dropList.flatMap {
case u: UnresolvedAttribute =>
- resolveExpressionByPlanChildren(u, d)
- case e => e
+ if (u.getTagValue(LogicalPlan.PLAN_ID_TAG).nonEmpty) {
Review Comment:
to confirm: the plan node `DataFrameDropColumns` can only come from Spark
Connect, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
