cloud-fan commented on code in PR #51196:
URL: https://github.com/apache/spark/pull/51196#discussion_r2176526024
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala:
##########
@@ -509,6 +509,31 @@ trait ColumnResolutionHelper extends Logging with
DataTypeErrorsBase {
includeLastResort = includeLastResort)
}
+ // Try to resolve `UnresolvedAttribute` by the children with Plan Ids.
+ // If the `UnresolvedAttribute` doesn't have a Plan Id, return None.
Review Comment:
shall we just add an assertion to guarantee it? The caller only call
`tryResolveColumnByPlanChildren` with the `UnresolvedAttribute` has plan id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
