mihailom-db commented on code in PR #51335:
URL: https://github.com/apache/spark/pull/51335#discussion_r2177708058
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1340,7 +1340,20 @@ collateClause
: COLLATE collationName=multipartIdentifier
;
-type
+primitiveTypeWithParameters
+ : STRING collateClause?
Review Comment:
It can go, but in this case I would say collation is a parameter as well. It
can change it's value to some different value not known at parsing time. If we
follow this case, then probably INTERVAL should go to
primitiveTypeWithoutParameters, as it is actually without parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
