mihailom-db commented on code in PR #51335:
URL: https://github.com/apache/spark/pull/51335#discussion_r2191651085
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1349,32 +1358,26 @@ type
| FLOAT | REAL
| DOUBLE
| DATE
- | TIME
- | TIMESTAMP | TIMESTAMP_NTZ | TIMESTAMP_LTZ
- | STRING collateClause?
- | CHARACTER | CHAR
- | VARCHAR
+ | TIMESTAMP_LTZ | TIMESTAMP_NTZ | TIMESTAMP (WITHOUT TIME ZONE)?
| BINARY
- | DECIMAL | DEC | NUMERIC
| VOID
| INTERVAL
Review Comment:
Moved both INTERVAL and TIMESTAMP so that in the code it is clear that
trivial types do not require post processing, but only return a specific type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
