cloud-fan commented on code in PR #51117:
URL: https://github.com/apache/spark/pull/51117#discussion_r2212305187


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala:
##########
@@ -317,21 +317,43 @@ private[aggregate] object CollectTopK {
 case class ListAgg(

Review Comment:
   we should update `def children` to use the actual constructor parameters, 
instead of `SortOrder`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to