cloud-fan commented on code in PR #51117:
URL: https://github.com/apache/spark/pull/51117#discussion_r2212308396
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala:
##########
@@ -258,12 +258,18 @@ object RewriteDistinctAggregates extends
Rule[LogicalPlan] {
def patchAggregateFunctionChildren(
af: AggregateFunction)(
attrs: Expression => Option[Expression]): AggregateFunction = {
- val newChildren = af.children.map(c => attrs(c).getOrElse(c))
+ val newChildren = af.children.map {
+ case so: SortOrder =>
Review Comment:
We have `withOrderingWithinGroup` to update the sort order, why sort
direction and null ordering needs to be in the children?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
