cloud-fan commented on code in PR #51466:
URL: https://github.com/apache/spark/pull/51466#discussion_r2236371611
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -132,7 +132,11 @@ object TableOutputResolver extends SQLConfHelper with
Logging {
case (valueType, colType) if
DataType.equalsIgnoreCompatibleNullability(valueType, colType) =>
val canWriteExpr = canWrite(
tableName, valueType, colType, byName = true, conf, addError,
colPath)
- if (canWriteExpr) checkNullability(value, col, conf, colPath) else
value
+ if (canWriteExpr) {
+ applyColumnMetadata(checkNullability(value, col, conf, colPath), col)
Review Comment:
so the change in this PR is to propogate the attribute metadata more
completely through `TableOutputResolver`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
