ksbeyer commented on code in PR #51466:
URL: https://github.com/apache/spark/pull/51466#discussion_r2237984349
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharVarcharUtils.scala:
##########
@@ -90,9 +90,16 @@ object CharVarcharUtils extends Logging with
SparkCharVarcharUtils {
* the given attribute's metadata.
*/
def cleanAttrMetadata(attr: AttributeReference): AttributeReference = {
- val cleaned = new MetadataBuilder().withMetadata(attr.metadata)
- .remove(CHAR_VARCHAR_TYPE_STRING_METADATA_KEY).build()
- attr.withMetadata(cleaned)
+ attr.withMetadata(cleanMetadata(attr.metadata))
+ }
+
+ /**
+ * Removes the metadata entry that contains the original type string of
CharType/VarcharType from
+ * the given metadata.
+ */
+ def cleanMetadata(metadata: Metadata): Metadata = {
+ new MetadataBuilder().withMetadata(metadata).
+ remove(CHAR_VARCHAR_TYPE_STRING_METADATA_KEY).build()
Review Comment:
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
