anishshri-db commented on PR #51959: URL: https://github.com/apache/spark/pull/51959#issuecomment-3300226353
@cloud-fan - few thoughts here: - I feel like we should still retain the new dir structure. Atleast it helps to organize code/components logically. Otherwise, we just have a ton of files in a single dir - In the longer term, I feel like we should also allow for the package names to reflect this structure within spark code as well as external dependencies. Btw, is it expected for external sources to rely on `spark.sql.execution` imports. I understand not breaking stuff under `sql/api` but I feel like we should have some path to allow us to make this transition - since this seems like an engine internal in many ways. I guess the only way is to allow both import paths for a few releases ? not sure if we could scope this down to only some list of imports to keep the changes contained ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
