HeartSaVioR commented on PR #51959: URL: https://github.com/apache/spark/pull/51959#issuecomment-3301146083
Hmm OK they are actually following what we do with Kafka data source. HDFSMetadataLog and SerializedOffset are probably something 3rd party would use if they copy and modify the built-in data source. Ideally speaking, we should rather consider moving these classes to the common package (execution package is definitely an internal one), but that effort will leave pulsar to be still broken, so probably better to be only done with major release, with discussion in prior. I'm fine whatever way to fix this issue - 1) revert entirely 2) revert case by case 3) don't revert but add alias classes (extends the refactored class but having the old name) for compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
