cloud-fan commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2374359814
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -40,6 +40,12 @@ options { tokenVocab = SqlBaseLexer; }
* When true, double quoted literals are identifiers rather than STRINGs.
*/
public boolean double_quoted_identifiers = false;
+
+ /**
+ * When false, parameter markers (? and :param) are only allowed in constant
contexts.
+ * When true, parameter markers are allowed everywhere a literal is
supported.
+ */
+ public boolean parameter_substitution_enabled = true;
}
Review Comment:
This PR does not touch the CREATE TABLE parser rule, how do we support
parameter markers there? Or it's already supported before this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
