cloud-fan commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2374374284
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -138,7 +165,7 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
}
} else {
val badType = typeCtx.unsupportedType.getText
- val params = typeCtx.INTEGER_VALUE().asScala.toList
+ val params = typeCtx.integerValue().asScala.map(_.getText).toList
Review Comment:
So the assumption here is the parameter markers should have been replaces
and we can safely get the original INTEGER_VALUE text?
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -138,7 +165,7 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
}
} else {
val badType = typeCtx.unsupportedType.getText
- val params = typeCtx.INTEGER_VALUE().asScala.toList
+ val params = typeCtx.integerValue().asScala.map(_.getText).toList
Review Comment:
So the assumption here is the parameter markers should have been replaced
and we can safely get the original INTEGER_VALUE text?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
