AnishMahto commented on code in PR #55836: URL: https://github.com/apache/spark/pull/55836#discussion_r3244435792
########## sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/autocdc/ChangeArgs.scala: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.pipelines.autocdc + +import org.apache.spark.sql.{AnalysisException, Column} +import org.apache.spark.sql.catalyst.parser.CatalystSqlParser +import org.apache.spark.sql.types.StructType + +/** + * A column reference that must be a single, unqualified identifier (no nested field path and + * no table/alias qualifier). The constructor parses [[name]] with the Spark SQL parser and + * throws an [[AnalysisException]] if it does not resolve to exactly one name part. + */ +case class UnqualifiedColumnName(name: String) { Review Comment: Fair enough. We're in a bit of weird position interface wise; when matching against field names in `StructType`, the expectation is Spark has already stripped away the backticks, and therefore we need to do the same to compare. Conversely when doing column references (ex. `F.col`), we cannot simply strip away/consume the backticks, because that changes whether the analyzer will treat the column as nested or single part. We have usages for both within the planned AutoCDC implementation, but only the former within this PR. I accepted the suggestion but added a `quoted` helper for the latter, which will be useful in following PRs. Added test `UnqualifiedColumnName.quoted is safe to pass to functions.col for literal-dot names` to demonstrate this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
