yaooqinn commented on code in PR #55901:
URL: https://github.com/apache/spark/pull/55901#discussion_r3252392774
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledJoin.scala:
##########
@@ -46,7 +46,8 @@ trait ShuffledJoin extends JoinCodegenSupport {
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
- PartitioningCollection(Seq(left.outputPartitioning,
right.outputPartitioning))
+ PartitioningCollection.fromPartitionings(
+ Seq(left.outputPartitioning, right.outputPartitioning))
Review Comment:
Should `BroadcastHashJoinExec.scala:87` (`case ps =>
PartitioningCollection(ps)` in `expandOutputPartitioning`) and
`AliasAwareOutputExpression.scala:43` (`case ps => PartitioningCollection(ps)`
in `outputPartitioning`) also use this new `fromPartitionings` factory for
consistency? Both build a `PartitioningCollection` from independently-computed
partitionings that may contain `KeyedPartitioning`s, which looks like the same
scenario `fromPartitionings` was introduced for. Or are these intentionally
left as direct construction because the inputs already satisfy the
`partitionKeys eq` invariant by other means?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
