peter-toth commented on code in PR #55901:
URL: https://github.com/apache/spark/pull/55901#discussion_r3252811913
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledJoin.scala:
##########
@@ -46,7 +46,8 @@ trait ShuffledJoin extends JoinCodegenSupport {
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
- PartitioningCollection(Seq(left.outputPartitioning,
right.outputPartitioning))
+ PartitioningCollection.fromPartitionings(
+ Seq(left.outputPartitioning, right.outputPartitioning))
Review Comment:
Techincally, `.fromPartitionings()` is not necessary in
`BroadcastHashJoinExec` and in `AliasAwareOutputExpression`, but it is kind of
a no-op when the input already satisfies the invariant, so we can make them
consistent. Changed in
https://github.com/apache/spark/commit/a4329cc0cab770dd466e528d9a42b348f1ece5f1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
