Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111429204
Also note the `[UnnecessaryStaticImport] Using static imports for types is
unnecessary` conflict with a scaladoc walk around:
[SPARK-7726](https://github.com/apache/spark/pull/6260/files)
(`UnnecessaryStaticImport ` is also a warning by default.)
/Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/OpenBlocks.java:28:
error: [UnnecessaryStaticImport] Using static imports for types is unnecessary
import static
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;
^
(see http://errorprone.info/bugpattern/UnnecessaryStaticImport)
Did you mean 'import
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'?
/Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/StreamHandle.java:24:
error: [UnnecessaryStaticImport] Using static imports for types is unnecessary
import static
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;
^
(see http://errorprone.info/bugpattern/UnnecessaryStaticImport)
Did you mean 'import
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'?
/Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RegisterExecutor.java:26:
error: [UnnecessaryStaticImport] Using static imports for types is unnecessary
import static
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;
^
(see http://errorprone.info/bugpattern/UnnecessaryStaticImport)
Did you mean 'import
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'?
/Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlock.java:28:
error: [UnnecessaryStaticImport] Using static imports for types is unnecessary
import static
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;
^
(see http://errorprone.info/bugpattern/UnnecessaryStaticImport)
Did you mean 'import
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'?
4 errors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
