Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111434507
/Users/yijie/code/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/BaseRow.java:143:
error: [TypeParameterUnusedInFormals] Declaring a type parameter that is only
used in the return type is a misuse of generics: operations on the type
parameter are unchecked, it hides unsafe casts at invocations of the method,
and it interacts badly with method overload resolution
public <T> T getAs(int i) {
^
(see http://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
Did you mean 'public Object getAs(int i) {'?
/Users/yijie/code/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/BaseRow.java:148:
error: [TypeParameterUnusedInFormals] Declaring a type parameter that is only
used in the return type is a misuse of generics: operations on the type
parameter are unchecked, it hides unsafe casts at invocations of the method,
and it interacts badly with method overload resolution
public <T> T getAs(String fieldName) {
^
(see http://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
Did you mean 'public Object getAs(String fieldName) {'?
2 errors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
