jiwen624 commented on code in PR #55329:
URL: https://github.com/apache/spark/pull/55329#discussion_r3327749640
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoSchemaEvolutionBasicTests.scala:
##########
@@ -1265,4 +1265,42 @@ trait MergeIntoSchemaEvolutionBasicTests extends
MergeIntoSchemaEvolutionSuiteBa
expected = Seq((1, "hr")).toDF("pk", "dep"),
expectedWithoutEvolution = Seq((1, "hr")).toDF("pk", "dep")
)
+
+ for (colName <- Seq("job.title", "job title")) {
Review Comment:
Yes, I removed them as the PR description only mentions dot and space and
even with `1st` and `from` in the test cases they still don't cover all the
"special characters" - I can add them back and update the PR desc if these two
are valuable to exercise the fix. Also I changed it from "multiple columns at
once" to a loop testing each case separately so the first failed column doesn't
mask the others, as the error/exception are different for them. This can also
explicitly show what specific cases we're testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
