jiwen624 commented on code in PR #55329:
URL: https://github.com/apache/spark/pull/55329#discussion_r3328106583
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoSchemaEvolutionBasicTests.scala:
##########
@@ -1265,4 +1265,42 @@ trait MergeIntoSchemaEvolutionBasicTests extends
MergeIntoSchemaEvolutionSuiteBa
expected = Seq((1, "hr")).toDF("pk", "dep"),
expectedWithoutEvolution = Seq((1, "hr")).toDF("pk", "dep")
)
+
+ for (colName <- Seq("job.title", "job title")) {
Review Comment:
I need to correct myself here (sorry to have confused you): `1st` and `from`
can be handled properly (not failing) with/without the fix so they, although
looking like “special cases” too, may not be good candidates to demonstrate the
issue/fix. (The remaining two cases: col name with dot or space fail without
the fix and pass with it. ) Because of this, I wouldn't recommend adding them
back as it could be misleading - does that sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
