liucao-dd commented on code in PR #56705:
URL: https://github.com/apache/spark/pull/56705#discussion_r3550174515
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/RowLevelOperation.java:
##########
@@ -39,7 +39,7 @@ public interface RowLevelOperation {
* @since 3.3.0
*/
enum Command {
- DELETE, UPDATE, MERGE
+ DELETE, UPDATE, MERGE, REPLACE
Review Comment:
How about ROW_LEVEL_REPLACE? The enum is describing the kind of row-level
operation and not necessarily the SQL grammar. Though the existing 3 are all
non-ambiguously matching the SQL grammar. So happy to adopt your suggestion as
well if we do not anticipate this being used by anything other than INSERT INTO
REPLACE USING/ON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
