longvu-db commented on code in PR #56705: URL: https://github.com/apache/spark/pull/56705#discussion_r3561421729
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsRowLevelReplace.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import org.apache.spark.annotation.Experimental; +import org.apache.spark.sql.connector.write.RowLevelOperation; + +/** + * A mix-in interface for {@link SupportsRowLevelOperations} that signals a table can handle the + * {@link RowLevelOperation.Command#REPLACE} command. + * <p> + * Spark dispatches {@code INSERT INTO ... REPLACE USING (cols)} through this command. + * {@link RowLevelOperation.Command#REPLACE} is dispatched to a connector's + * {@link SupportsRowLevelOperations#newRowLevelOperationBuilder} only when the table implements Review Comment: @liucao-dd Good point, I think INSERT REPLACE USING would need a new trait, since it is different from MERGE/UPDATE/DELETE in the sense that it is a group-of-rows-based replacement, i.e. one can replace 2 rows in the target table with 5 rows from the source query, whereas MERGE is a 1:1 row-based replacement, it fails when multiple source rows match and attempt to update the same target row. I'm not sure yet on whether it should extend the existing `SupportRowLevelOperations`, will get back to you on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
