szehon-ho commented on code in PR #57357:
URL: https://github.com/apache/spark/pull/57357#discussion_r3618305420
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala:
##########
@@ -93,6 +93,19 @@ object PushDownUtils extends Logging {
(postScanFilters ++ untranslatableExprs).toImmutableArraySeq)
case r: SupportsPushDownV2Filters =>
+ // Non-deterministic filters must not be pushed down: a data source
may evaluate a pushed
Review Comment:
this comment is a bit contradictory, maybe must => should.
as the flag is going to push them down anyway
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala:
##########
@@ -93,6 +93,19 @@ object PushDownUtils extends Logging {
(postScanFilters ++ untranslatableExprs).toImmutableArraySeq)
case r: SupportsPushDownV2Filters =>
+ // Non-deterministic filters must not be pushed down: a data source
may evaluate a pushed
Review Comment:
this comment is a bit contradictory, maybe must => should.
as the flag is going to push them if the user chooses to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
