aokolnychyi commented on code in PR #57357:
URL: https://github.com/apache/spark/pull/57357#discussion_r3626337656


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -7864,6 +7864,20 @@ object SQLConf {
       .createWithDefault(false)
   }
 
+  val LEGACY_ALLOW_NON_DETERMINISTIC_V2_FILTER_PUSHDOWN =

Review Comment:
   If we absolutely need this, then some method on the 
`SupportsPushDownV2Filters` API would be OKish. That said, are we sure it is 
always safe to do, even in case of JDBC?



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -7864,6 +7864,20 @@ object SQLConf {
       .createWithDefault(false)
   }
 
+  val LEGACY_ALLOW_NON_DETERMINISTIC_V2_FILTER_PUSHDOWN =

Review Comment:
   Each connector must decide this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to