szehon-ho commented on code in PR #57357:
URL: https://github.com/apache/spark/pull/57357#discussion_r3632797773
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -7864,6 +7864,20 @@ object SQLConf {
.createWithDefault(false)
}
+ val LEGACY_ALLOW_NON_DETERMINISTIC_V2_FILTER_PUSHDOWN =
Review Comment:
But the flag is not going to work. (If most connectors depend on new
behavior, and suddenly we flip it)
One option is:
- a hidden API on SupportsPushdownV2Filters that defaults to false, and
javadoc'ed to say 'do not do this unless very sure'
- and a jdbc specific flag to return true
Or not even have a flag works for me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
