cloud-fan commented on code in PR #57859:
URL: https://github.com/apache/spark/pull/57859#discussion_r3746972044
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/CombineAdjacentAggregationSuite.scala:
##########
@@ -191,6 +192,54 @@ class CombineAdjacentAggregationSuite extends QueryTest
}
}
+ test("Combine adjacent partial merge and final hash aggregates") {
Review Comment:
Thanks for raising this. OSS does not currently produce a pure adjacent
PartialMerge -> Final HashAggregate pair from a built-in query plan. The rule
is intended to handle plans produced by physical-plan extensions that add an
aggregation stage, and I updated the class documentation to say that explicitly.
The test now constructs a valid executable Partial -> PartialMerge -> Final
pipeline, applies the rule to the upper pair, and compares the uncombined and
combined execution results. This replaces the previous plan-shape-only
coverage. I also added a separate end-to-end query test for the AQE
rebalance/skew distribution regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
