cloud-fan commented on PR #57859:
URL: https://github.com/apache/spark/pull/57859#issuecomment-5243431832
Thanks, @dongjoon-hyun. Addressed these comments in 296a85085d6:
- updated the PR description to distinguish the upper aggregate's
distribution requirement from
the lower aggregate's child-facing streaming and shuffle metadata, and
removed the claim about
an explicit output/input equality check;
- removed the redundant `requiredChildDistributionExpressions` copy argument
and added a comment
explaining why the remaining metadata comes from different nodes;
- replaced the `AggregateMode`/exception match with an explicit combined
aggregate result;
- clarified that `PartialMerge` + `Final` is supported only for
`HashAggregateExec`;
- made the AQE partition-spec assertion non-vacuous.
The focused suite (10 tests) and `sql/scalastyle` both pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
