nchammas opened a new pull request, #57973: URL: https://github.com/apache/spark/pull/57973
### What changes were proposed in this pull request? Trim unnecessary commands from MANIFEST.in. Tweak the various setup.py files to subsume their behavior. ### Why are the changes needed? Having duplicate (and unnecessary!) packaging specs across setup.py and MANIFEST.in is [confusing]. The explicit `license_files` argument is not necessary -- setuptools packages these files by default -- but nice to have since it's explicit. [confusing]: https://github.com/apache/spark/pull/57763#issuecomment-5262613111 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I built the three sdists off of master and then again from this branch. I diffed their contents and found no differences. ```bash set -euo pipefail # from inside python/ mkdir -p dist for pkg in classic client connect; do echo "=== $pkg ===" rm -f dist/pyspark*.tar.gz # --- before (master) --- git checkout master python packaging/$pkg/setup.py sdist mv dist/pyspark*.tar.gz dist/$pkg-before.tar.gz tar -tzf dist/$pkg-before.tar.gz | sort > dist/sdist-$pkg-before.txt # --- after (this branch) --- git checkout pyspark-manifest-cleanup python packaging/$pkg/setup.py sdist mv dist/pyspark*.tar.gz dist/$pkg-after.tar.gz tar -tzf dist/$pkg-after.tar.gz | sort > dist/sdist-$pkg-after.txt diff -u dist/sdist-$pkg-before.txt dist/sdist-$pkg-after.txt | tee dist/sdist-$pkg.diff || true done ``` Our CI packaging tests are a bit slim. I've separately proposed #57645 to make them more comprehensive. ### Was this patch authored or co-authored using generative AI tooling? I wrote the test script with assistance from GitHub Copilot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
