nchammas commented on code in PR #57973:
URL: https://github.com/apache/spark/pull/57973#discussion_r3778966742
##########
python/packaging/classic/setup.py:
##########
@@ -340,8 +340,9 @@ def run(self):
"pyspark.examples.src.main.python": "deps/examples",
},
package_data={
- "pyspark.jars": ["*.jar"],
- "pyspark.bin": ["*"],
+ "pyspark": ["**/*.pyi", "**/py.typed", "**/*.json"],
Review Comment:
Note that setuptools packages `.pyi` and `py.typed` files by default in
v69+. However, this is [marked as experimental behavior][1], so it's better to
keep these as explicit includes.
[1]:
https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html#:~:text=Please%20note%20however%20that%20this%20feature%20is%20EXPERIMENTAL%20and%20may%20change%20in%20the%20future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
