anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5352071816
Thanks for the detailed review @cloud-fan , have addressed all three points: - Replaced `equals` with `TypeUtils.getInterpretedOrdering(dt).compare(...)` for correct Catalyst equality - Hoisted output schema and per-field orderings/types out of the candidate loop - Capitalized "Result" in the comment - Added binary-column regression test Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
