anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5359886726
Thanks for the review @cloud-fan , have addressed all three points: - Derive LHS nullability from `valExprs` for `CreateNamedStruct` so nullable LHS fields are correctly propagated through generated NOT IN code - Split result rows into a TreeSet of fully non-null rows (O(log n) indexed lookup) and an array of null-containing rows (linear scan only when needed) - Fixed comment to 5+5=10 rows - Added nullable-LHS/non-nullable-RHS codegen regression test Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
