anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5413398465
Thanks for the review @cloud-fan , have addressed both: - Gated the `CreateNamedStruct/valExprs` nullability path on plan.output.length > 1, so a user-written single struct-valued IN correctly falls through to `child.nullable` instead of picking up field-level nullability meant only for the generated multi-column carrier - Added early returns before `inputFields` materialization when there are no candidates to scan (empty `multiColNullRows` in the non-null-LHS path; both collections empty in the nullable-LHS path) - Switched rhs to a VALUES-derived temp view in the nullable-LHS regression so it actually stays non-nullable instead of being widened by Parquet's dataSchema.asNullable Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
