dongjoon-hyun opened a new pull request, #58369:
URL: https://github.com/apache/spark/pull/58369

   ### What changes were proposed in this pull request?
   
   This PR makes the `Download` control of the SQL execution page a real 
button, aligned with the neighboring `Copy Plan` and `Copy Link` buttons.
   
   - Replace the `<label>`-wrapped `<a class="downloadbutton">` with a 
`<button>` using the same classes as the other buttons, and add a download icon 
and a `title` tooltip.
   - Change `Copy Link` from `ms-1` to `ms-2` so that all three buttons are 
evenly spaced.
   - Add an `aria-label` to the format `<select>`, which lost its accessible 
name with the removed `<label>`.
   
   ### Why are the changes needed?
   
   `Download` was a plain text link next to two Bootstrap buttons, so it was 
shorter than them, and `margin-right: 10px` from `a.downloadbutton` made the 
gaps between the three controls uneven.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, but it is a UI-only change in the unreleased master branch. `Download` 
is now a button with an icon, and its functionality is unchanged.
   
   ### How was this patch tested?
   
   Manually checked the SQL execution page in a browser. No test was added 
because this only changes the Web UI markup.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to