LukaZdravic opened a new pull request, #58630:
URL: https://github.com/apache/spark/pull/58630
### What changes were proposed in this pull request?
Follow-up to SPARK-59299 (#58578) addressing a review comment.
`PlanParserSuite`'s
`test("asof join")` bundled nine positive `ASOF JOIN` parsing cases under
one test name. This
splits them so each scenario is its own named test:
- `asof join` - basic `MATCH_CONDITION` (`t.a >= u.a`), retained as the
canonical case;
- `asof join - left asof with on condition`;
- `asof join - using single join column` / `... multiple join columns`;
- `asof join - less than or equal / greater than / less than match operator`;
- `asof join - explicit inner / left outer join type`.
No assertions were changed - the existing cases are only redistributed into
separate tests
(the diff is purely additive).
### Why are the changes needed?
With all cases in one `test(...)` block, a failure is reported only as `asof
join` without
indicating which case broke, and the first failing assertion aborts the
block so the remaining
cases never run. One scenario per test makes failures self-identifying and
independent,
matching the surrounding `asof join - ...` tests in the same suite.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Test-only change: the existing `test("asof join")` assertions are only
redistributed into
separately-named tests, with no assertion modified (the diff is purely
additive). Coverage is
verified by this PR's GitHub Actions CI, which compiles `sql/catalyst` and
runs
`PlanParserSuite`.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
