vranes commented on code in PR #58630:
URL: https://github.com/apache/spark/pull/58630#discussion_r3959777116
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##########
@@ -1056,7 +1056,11 @@ class PlanParserSuite extends AnalysisTest {
$"u.a",
None,
Inner).select(star()))
+ }
+ }
+ test("asof join - left asof with on condition") {
Review Comment:
nit: "explicit left join type with on condition", to match other explicit
join type tests below
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##########
@@ -1067,7 +1071,11 @@ class PlanParserSuite extends AnalysisTest {
$"u.a",
Some($"t.b" === $"u.b"),
LeftOuter).select(star()))
+ }
+ }
+ test("asof join - using single join column") {
Review Comment:
nit: "using with a single join column", same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
