HyukjinKwon commented on code in PR #58639:
URL: https://github.com/apache/spark/pull/58639#discussion_r3974022612
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedDeltaByteArrayReader.java:
##########
@@ -120,6 +140,7 @@ private void readGeoData(int total, WritableColumnVector c,
int rowId, int srid,
WKBConverterStrategy converter) {
for (int i = 0; i < total; i++) {
int prefixLength = prefixLengthVector.getInt(currentRow);
+ checkPrefixLength(prefixLength);
Review Comment:
The new tests cover the readBinary and skipBinary paths but not this geo
path (readGeometry/readGeography), which copies the prefix with
`previous.get(wkb, 0, prefixLength)` rather than the `appendBytes(...)` the
other two use. A corrupt-prefix geometry/geography case would exercise that
distinct copy behind the same guard. Consider a geo craft-page test, or
parametrizing `craftPage`/the existing tests over the read method. Non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
