dongjoon-hyun commented on PR #58639:
URL: https://github.com/apache/spark/pull/58639#issuecomment-5628812688
Thank you, @holdenk. The bound (`previous.remaining()`) matches all three
copy sites, and the change looks correct to me.
1. Could you add a boundary case, e.g. `prefixLengths = Array(0, 3),
suffixes = Array("ab", "")`? With on-heap vectors, `previous.array()` is the
whole child `byteData`, so an off-by-one prefix within capacity silently copied
stale bytes before this fix (65536 already failed with AIOOBE). A passing
`Array(0, 2)` case would also pin the valid boundary.
2. Nit: please use 4-space continuation indentation for the `throw new
ParquetDecodingException(` lines, consistent with 701d5e9768d.
3. Please use the `Generated-by: <tool name and version>` format in the AI
tooling section of the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
